HomePhorge

perf: move to filter map from map and filter
f20bdc386066Unpublished

Unpublished Commit · Learn More

  • Repository Importing: This repository is still importing.
  • Not On Permanent Ref: This commit is not an ancestor of any permanent ref.

Description

perf: move to filter map from map and filter

Instead of doing two passes of all candidates using map then a filter,
this uses filter_map so we are only doing one pass for the candidates.
This alone is quite a significant improvement of ~7%

Output of ./scripts/bench 0.x

Benchmark 1: 0.x

Time (mean ± σ):      2.373 s ±  0.138 s    [User: 10.617 s, System: 1.697 s]
Range (min … max):    2.124 s …  2.577 s    10 runs

Benchmark 2: HEAD

Time (mean ± σ):      2.206 s ±  0.133 s    [User: 10.061 s, System: 1.811 s]
Range (min … max):    1.940 s …  2.433 s    10 runs

Summary

HEAD ran
  1.08 ± 0.09 times faster than 0.x

The percentage difference is -7.00%

Details

Provenance
AdeAttwoodAuthored on Nov 30 2023, 2:07 PM
Parents
R1:6a57a15e4bf6: fix(deps): update rust crate ignore to 0.4.21
Branches
Unknown
Tags
Unknown

Event Timeline